[stable/redis-ha] ✨ feat: multiple values for redis configs #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
mhkarimi1383
force-pushed
the
feat-multiple-modules
branch
from
70a274d to
d52c06a
Compare
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
mhkarimi1383
force-pushed
the
feat-multiple-modules
branch
from
0a0493e to
8facbaf
Compare
mhkarimi1383
changed the title
|
I didn't find that |
|
Apparently we just use base values right now, but we could include a specific ci.yaml that can handle all the test cases. I thought we already had this! I was wrong. But under the |
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
|
@DandyDeveloper I added a values file for testing, etc. As my reading that should work without any changes in https://github.com/dandydeveloper/charts/blob/f39ee0e89964e90e781c682d5333f65b75083eaf/.ci/ct-config.yaml |
DandyDeveloper
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When we need to have multiple values for some configs (e.g. loadmodule), yaml is not okay with multiple values for the same key.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])