Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chart/redis-ha] Make exporter probes optional #228

Conversation

sonrai-doyle
Copy link
Contributor

What this PR does / why we need it:

This adds the option to remove the livenessProbe and readinessProbe from the exporter container.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@DandyDeveloper
Copy link
Owner

@sonrai-doyle May be better here to do a toYaml templating for the probes that way if people want to remove it they just add the following to the values file:

livenessProbe: {}

@DandyDeveloper
Copy link
Owner

@sonrai-doyle Any way you can update / give input on my comment? Will close soon if I don't hear from you.,

@sonrai-doyle
Copy link
Contributor Author

Sorry @DandyDeveloper missed your comment while I was away on vacation. Will look at making the suggested change as I can.

@mhkarimi1383
Copy link
Contributor

+1 Waiting for this, sometimes Redis wants to recover, and we want exporter to be enabled (without probes) since it will get timeouts, etc. and makes entire pod to be unavailable.

@sonrai-doyle sonrai-doyle force-pushed the fix/optional-exporter-checks branch 2 times, most recently from ba79365 to e751019 Compare March 9, 2023 13:22
@sonrai-doyle sonrai-doyle force-pushed the fix/optional-exporter-checks branch from e751019 to 9242c74 Compare March 9, 2023 13:23
@sonrai-doyle
Copy link
Contributor Author

@DandyDeveloper Sorry for the delay in addressing your comments. Would you be able to re-review?

@mhkarimi1383
Copy link
Contributor

mhkarimi1383 commented Mar 9, 2023

@sonrai-doyle
But that would be better if we can make all of the probes optional (some times we want to disable probes for all of the containers for debugging, etc.)

@DandyDeveloper DandyDeveloper merged commit 4f0811b into DandyDeveloper:master Apr 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants