-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts/redis-ha] fix: redis and haproxy and busybox image was migrated from docker hub to public ecr for docker hub rate limit #214
Conversation
… for docker hub rate limit Signed-off-by: kahirokunn <[email protected]>
…cr for docker hub rate limit Signed-off-by: kahirokunn <[email protected]>
…cr for docker hub rate limit Signed-off-by: kahirokunn <[email protected]>
@kahirokunn I'm not seeing any mentions of this being an official migration? https://hub.docker.com/_/redis Can you throw me something confirming this as an official migration? |
What about Google's cache proxy for DockerHub? |
@kahirokunn I'm gonna see if I can dig and find an official word that its right to use this. Sorry for the delay. |
@DandyDeveloper I did find an official announcement from docker. I think it's best to leave it to the default of |
If you are considering a rate limit, I would suggest using a registry that is mirrored by docker.io. AWS, GCP, GitHub, whatever, but a trusted and proven organization is preferred. In fact I got stuck with docker.io's rate limit and failed in production. |
I think we're in a significantly better place now than we were 2 years ago to merge this in :) I've updated to the official ECR repos now. |
@kahirokunn |
@kahirokunn CI says no, and that was a mistake on my part! Sorry! |
That's because paths and user accesses are not standard. |
@mhkarimi1383 Because I messed up the commit. :) |
I mean I would prefer using official images since bitnami images are non root and non standard |
@mhkarimi1383 Yes. I am using the official ones. We don't want Bitnami. I committed the wrong images (See latest commit) |
Thx! |
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)