Virtual server folder with keys management #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dahlgren
commented
Apr 14, 2020
Dahlgren
commented
May 18, 2020
Dahlgren
force-pushed
the
feature/virtual-server-folder
branch
2 times, most recently
from
7a44f62
to
a1e36b0
Compare
|
Chances on getting this pulled into master, along with some documentation on how to use it? Would be a great feature to have. |
|
This looks fantastic, is there anything required for it to be merged? |
Dahlgren
force-pushed
the
feature/virtual-server-folder
branch
5 times, most recently
from
6b540fa
to
6d545b1
Compare
|
is there anything I could help with? |
Dahlgren
force-pushed
the
feature/virtual-server-folder
branch
6 times, most recently
from
0543fd9
to
5e5b2e3
Compare
|
Potential fix for firewall issue: |
|
Whitelisting the ports in Windows firewall also works. Changing the firewall rules probably needs UAC. |
|
Please continue to ignore me, issues were my end. |
Dahlgren
force-pushed
the
feature/virtual-server-folder
branch
from
5e5b2e3
to
aeb8956
Compare
Dahlgren
force-pushed
the
feature/virtual-server-folder
branch
from
aeb8956
to
47bcc9c
Compare
Dahlgren
force-pushed
the
feature/virtual-server-folder
branch
3 times, most recently
from
f8fd025
to
2e75733
Compare
Dahlgren
force-pushed
the
feature/virtual-server-folder
branch
from
2e75733
to
ffbe849
Compare
Dahlgren
force-pushed
the
feature/virtual-server-folder
branch
2 times, most recently
from
abdafa9
to
a124853
Compare
Dahlgren
force-pushed
the
feature/virtual-server-folder
branch
2 times, most recently
from
bb4aeb9
to
3c3ad02
Compare
Dahlgren
force-pushed
the
feature/virtual-server-folder
branch
2 times, most recently
from
6da1a48
to
d8199c5
Compare
Dahlgren
force-pushed
the
feature/virtual-server-folder
branch
from
d8199c5
to
310f77c
Compare
Dahlgren
force-pushed
the
feature/virtual-server-folder
branch
from
310f77c
to
8f31be1
Compare
Dahlgren
force-pushed
the
feature/virtual-server-folder
branch
from
8f31be1
to
9d152e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117
TODO
fs.promisesneeds to be changed to allow older Node versions, its only available in Node 10+