zad6 #264
Open
zad6 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahawrylak
reviewed
Dec 11, 2018
| def change | ||
| create_table :customers do |t| | ||
| t.string :name, null: false | ||
| t.string :mail, null: false |
There was a problem hiding this comment.
na poziomie bazy jest NULL CONSTRAINT na kolumnie mail, ale nie ma walidacji w modelu Customer - powinna się tam znaleźć żeby nie dostawać brzydkich błędów z bazy danych tylko błędy z modelu. 😉
| @@ -0,0 +1,9 @@ | |||
| class Product < ApplicationRecord | |||
| belongs_to :customer | |||
There was a problem hiding this comment.
Ta linia nie pozwala na stworzenie produktu, który nie ma jeszcze przypisanego customera. Można to poprawić w następujący sposób:
belongs_to :customer, optional: true| @@ -0,0 +1,9 @@ | |||
| class Product < ApplicationRecord | |||
| belongs_to :customer | |||
| has_many :categories, through: :category_product | |||
There was a problem hiding this comment.
Ta relacja zawsze będzie podnosiła błąd, tak jak tutaj:
Rzeczywiście nie ma tutaj zdefiniowanej relacji :category_product. Powinno być tak:
has_many :category_products
has_many :categories, through: :category_productsAnalogicznie z drugiej strony relacji w modelu Category 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.