Zad 5 + Zad6 #261
Open
Zad 5 + Zad6 #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zad1_v2
Merge branch 'master' of https://github.com/zakpat/ror4beginners2018 Merge branch 'master' of https://github.com/zakpat/ror4beginners2018
Merge branch 'master' of https://github.com/daftcode/ror4beginners2018
zad1_v2
resool
reviewed
Dec 12, 2018
| @@ -0,0 +1,2 @@ | |||
| module ArtistsHelper | |||
There was a problem hiding this comment.
railsy tworzą wiele plików przy generowaniu kontrolerów.
jak się jakiegoś nie używa to można spokojnie skasować 🚜
| <td><%= artist.name %></td> | ||
| <td class="text-right"> | ||
| <%= link_to 'edit', edit_artist_url(artist), class: 'btn btn-warning' %> | ||
| <%= link_to 'remove', artist_url(artist), class: 'btn btn-danger', method: :delete %> |
There was a problem hiding this comment.
można dodać data: { confirm: 'Are you sure?' }, aby przypadkiem nie usunąć niczego 🙈
|
Zdecydowanie tak, dodatkowe potwierdzenie byłoby wskazane 😉
W dniu śr., 12.12.2018 o 15:19 Szymon <[email protected]> napisał(a):
***@***.**** commented on this pull request.
------------------------------
In zad5/app/helpers/artists_helper.rb
<#261 (comment)>
:
> @@ -0,0 +1,2 @@
+module ArtistsHelper
railsy tworzą wiele plików przy generowaniu kontrolerów.
jak się jakiegoś nie używa to można spokojnie skasować 🚜
------------------------------
In zad5/app/views/artists/index.html.erb
<#261 (comment)>
:
> + <%= link_to 'Add new artist', new_artist_url, class: 'btn btn-success pull-right' %>
+ <h2>Artist Table</h2>
+ <table class="table">
+ <thead>
+ <tr>
+ <th class="text-left">Artists</th>
+ <th class="text-right">Actions</th>
+ </tr>
+ </thead>
+ <tbody>
+ <% @artists.each do |artist| %>
+ <tr>
+ <td><%= artist.name %></td>
+ <td class="text-right">
+ <%= link_to 'edit', edit_artist_url(artist), class: 'btn btn-warning' %>
+ <%= link_to 'remove', artist_url(artist), class: 'btn btn-danger', method: :delete %>
można dodać data: { confirm: 'Are you sure?' }, aby przypadkiem nie
usunąć niczego 🙈
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#261 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AqqG_AoFmmdSed3m-rCSY56gJFtOhiVlks5u4RBhgaJpZM4ZKKdi>
.
--
Z wyrazami szacunku
Patryk Żak
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Po kolejnym boju dostarczam na githubie zad 5. Wszelkie inne zmiany (w tym usuniete pliki) prosze zignorowac :)