Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for random and custom TC maker plugins #384

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

MRiganSUSX
Copy link
Contributor

A fix to make RandomTriggerCandidateMaker functional, including all configuration parameters.

RTCM is a standalone module that inserts TCs straight into the MLT.
These TCs can be created at a configurable frequency.
The are two methods when creating these: a flat distribution (kUniform) and a random Poisson distribution (kPoisson).
The time estimation can be done either via system clock or using the TimeSync messages.
More details are available here: slides

Example configuration for testing:

"trigger": { 

   "use_random_maker": true,
   "rtcm_timestamp_method": "kSystemClock",
   "rtcm_time_distribution": "kUniform",
   "rtcm_trigger_interval_ticks": 32000000

 }

Minimal configuration for testing (that uses defaults):

"trigger": {
   "use_random_maker": true,
...
 }

@bieryAtFnal
Copy link
Contributor

This PR is correlated with trigger PR 240.

Copy link
Contributor

@bieryAtFnal bieryAtFnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified that a representative subset of existing integtests continue to succeed with these changes. My vote is to go ahead and merge these changes and work on new integtest(s) that make use of the Random TC maker as a separate step.

@bieryAtFnal bieryAtFnal merged commit 47a8ec2 into develop Sep 25, 2023
2 checks passed
@bieryAtFnal bieryAtFnal deleted the mrigan/fix_random_tc_maker branch September 25, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants