FFS-873: Expense Ledger Add Screen #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YvetteWhiteUSDS
approved these changes
Jun 7, 2024
app/ledger/income/add/page.tsx
Outdated
| @@ -7,7 +7,7 @@ import { useAppDispatch } from "@/lib/hooks" | |||
| import { addIncome, IncomeItem } from "@/lib/features/ledger/income/incomeSlice" | |||
| import { useRouter } from "next/navigation" | |||
| import { FieldErrors, SubmitHandler, useForm, Controller } from "react-hook-form" | |||
| import TextFieldWithValidation from "./TextFieldWithValidation" | |||
| import TextFieldWithValidation from "../../../components/TextFieldWithValidation" | |||
There was a problem hiding this comment.
As mentioned earlier, figure out a way to remove the .. pathing.
Also, why does the TextFieldWithValidation file start with a capitalized letter while other tsx files start with lowercase? Is there a rationale. Thinking of conventions here and being consistent for better readability.
There was a problem hiding this comment.
@YvetteWhiteUSDS I updated the path's to use the @ shortcut to the root of the app. Regarding the component casing, I capitalized it to follow the pattern of the React USWDS library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
Confluence requirements
NOTE: Use of the React USWDS DatePicker component has added a warning to the build. The team that owns the component is aware of it.
Screenshots:
