-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added shared library and pkg-config support for libspdm #2402
Conversation
Changes: - spdm_device_secret_lib_sample has its own dump_hex_str_sample method - added pkg-config libspdm.pc.in file for cmake to use as template CMakeLists.txt changes: - added BUILD_SHARED_LIB cmake parameter (ON/OFF) to enable/disable building of libspdm.so in addition to the static libraries - added two build paths for libspdm.so that generate distinct pkg-config pc files, for runtime linking with either mbedtls or openssl Signed-off-by: Ionut Ursachi <[email protected]>
…initions related to it in the same cmake block. Updated pkg-config pc.in file to fix a small path naming error. Signed-off-by: Ionut Ursachi <[email protected]>
Hi, thank you for reviewing my change and for the feedback. I added some comments above and fixed some of the issues raised. |
@uvinrg what is the use case for this? Will this primarily be used to construct SPDM Requesters, Responders, or both? |
Hi Steven, the intent is to package libspdm as a regular shared library on linux distributions for future work around SPDM attestation. Depending on target platform and usecase, the libspdm shared library can act as either requester or responder. |
…generated and installed: libspdm.so libspdm_platform.so and libspdm_crypto.so. Added more information about them in build.md documentation. Shared libraries now properly link with their dependencies at runtime. Signed-off-by: Ionut Ursachi <[email protected]>
Sorry for the delay, I committed the new change with three shared libraries, one for libspdm, one for the platform code and one for the crypto libraries interfaces. Thank you. |
…vice_secret_lib_sample Signed-off-by: Ionut Ursachi <[email protected]>
Is it possible to add support to build shared libraries for Windows platform? Thanks a lot in advance. |
Unfortunately, I only used libspdm under linux, so I don't have the know-how. Feel free to add the Windows support if you need it. |
Changes:
CMakeLists.txt changes: