Add comment explaining MUT_AUTH_CAP check

Signed-off-by: Steven Bellock <[email protected]>
DMTF · Dec 23, 2024 · 4dd2800 · 4dd2800
1 parent 02aaa49
commit 4dd2800
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/library/spdm_requester_lib/libspdm_req_get_capabilities.c b/library/spdm_requester_lib/libspdm_req_get_capabilities.c
@@ -120,6 +120,9 @@ static bool validate_responder_capability(uint32_t capabilities_flag, uint8_t ve
 
         /* Checks that originate from mutual authentication capabilities. */
         if (mut_auth_cap == 1) {
+            /* Mutual authentication with asymmetric keys can only occur through the basic mutual
+             * authentication flow (CHAL_CAP == 1) or the session-based mutual authentication flow
+             * (KEY_EX_CAP == 1). */
             if ((key_ex_cap == 0) && (chal_cap == 0)) {
                 return false;
             }

diff --git a/library/spdm_responder_lib/libspdm_rsp_capabilities.c b/library/spdm_responder_lib/libspdm_rsp_capabilities.c
@@ -112,6 +112,9 @@ static bool libspdm_check_request_flag_compatibility(uint32_t capabilities_flag,
 
         /* Checks that originate from mutual authentication capabilities. */
         if (mut_auth_cap == 1) {
+            /* Mutual authentication with asymmetric keys can only occur through the basic mutual
+             * authentication flow (CHAL_CAP == 1) or the session-based mutual authentication flow
+             * (KEY_EX_CAP == 1). */
             if ((key_ex_cap == 0) && (chal_cap == 0)) {
                 return false;
             }