Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim in-repo copy of Martor #2378

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Conversation

Ninjaclasher
Copy link
Member

Also stop checking if a request is_ajax since this is now deprecated and was supposedly never a reliable indicator whether a request was ajax or not.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.72%. Comparing base (fd7fb05) to head (4f79e35).
Report is 44 commits behind head on master.

Files with missing lines Patch % Lines
martor/views.py 0.00% 2 Missing ⚠️
judge/views/widgets.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2378      +/-   ##
==========================================
+ Coverage   46.76%   47.72%   +0.95%     
==========================================
  Files         251      258       +7     
  Lines       13317    13707     +390     
==========================================
+ Hits         6228     6541     +313     
- Misses       7089     7166      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@quantum5 quantum5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one final question.

martor/settings.py Show resolved Hide resolved
martor/static/martor/js/martor.js Show resolved Hide resolved
@quantum5 quantum5 added this pull request to the merge queue Dec 26, 2024
Merged via the queue into DMOJ:master with commit 361b5ad Dec 26, 2024
3 checks passed
@Ninjaclasher Ninjaclasher deleted the trim-inrepo-martor branch December 27, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants