Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user admin object creation and deletion #2289

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

Ninjaclasher
Copy link
Member

Refs #931. Closes #2288.

  • Automatically create profile when adding a user through admin
  • Disallow adding profiles through admin
  • (Soft) disallow deleting profiles through admin

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 46.85%. Comparing base (98c7557) to head (ac40d03).
Report is 44 commits behind head on master.

Files with missing lines Patch % Lines
judge/admin/profile.py 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2289      +/-   ##
==========================================
+ Coverage   46.84%   46.85%   +0.01%     
==========================================
  Files         249      249              
  Lines       13158    13172      +14     
==========================================
+ Hits         6164     6172       +8     
- Misses       6994     7000       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

judge/admin/profile.py Outdated Show resolved Hide resolved
- Automatically create profile when adding a user through admin
- Disallow adding profiles through admin
- (Soft) disallow deleting profiles through admin
@Ninjaclasher Ninjaclasher force-pushed the fix-user-admin-create-delete branch from 305259e to ac40d03 Compare October 28, 2023 22:41
@Ninjaclasher Ninjaclasher requested a review from Xyene October 28, 2023 22:41
@Xyene Xyene added this pull request to the merge queue Oct 28, 2023
Merged via the queue into DMOJ:master with commit c3fb2d7 Oct 28, 2023
3 checks passed
@Ninjaclasher Ninjaclasher deleted the fix-user-admin-create-delete branch October 29, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants