-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit Form Alignment Fix #2176
Conversation
Can you please attach a screenshot of the before/after? |
What does the submit bar and language select look like? |
Yes, I noticed that and submit button and problem selection were also affected. |
resources/select2/_multiple.scss
Outdated
@@ -81,6 +81,10 @@ | |||
} | |||
|
|||
&.select2-container--focus { | |||
width: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ... not change values here, as they affect all select2 widgets across the entire site. If they are necessary, add them in problem.scss
inside i.e. #problem-submit
.
resources/problem.scss
Outdated
} | ||
|
||
#submit-wrapper { | ||
margin-top: 0.7em; | ||
margin-top: .2em; | ||
|
||
#editor, #language { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block is empty, just delete.
resources/base.scss
Outdated
@@ -86,7 +86,6 @@ th { | |||
.form-area { | |||
display: inline-block; | |||
background: $color_primary5; | |||
padding: 5px 10px 10px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, let's not change it globally unless you're sure this won't adversely affect any other form-area
across the entire site.
Codecov ReportBase: 46.80% // Head: 46.80% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #2176 +/- ##
=======================================
Coverage 46.80% 46.80%
=======================================
Files 239 239
Lines 13190 13190
=======================================
Hits 6173 6173
Misses 7017 7017 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
407b100
to
d338459
Compare
Changed the CSS properties for the alignment issue mentioned in #2171