Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about Tablet Huion #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

danghai
Copy link
Member

@danghai danghai commented May 30, 2018

PR to add more information about Tablet Huion

Copy link
Member

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Hai! I have a few comments/requests, but it's mostly great stuff :)

resolution: 5080
pen:
pressure_levels: 8192
frame_controls: 10 buttons, 1 touch bar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is interesting. Would be good to see what usbhid-dump reports for that touch bar and the buttons after uclogic-probe was executed on the tablet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why do you need the buttons? I see it has the frame_button.txt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I thought this was without the tablet enabled, but I see now that the reports are already right, which is good, thanks. It would be good to know what the user did there actually, though. I think I can see the 10 buttons being pressed, but I'm not sure which order was that. I think I can see the touch bar used, but I'm not sure which direction is which in the report, and what is the definite coordinate range. Do you still have contact with the user? Can you ask to make a new dump with a specific button press order, so we can find out, and another dump of the touch bar with clearly specified sequence of full-range movement, repeated several times so that we're sure we get the full range and the direction correctly? Better yet, if you could figure it all out yourself, so I can simply make a driver, and perhaps walk you through it :)

This has nothing to do with this PR, let's get this merged.

BTW, can you see the buttons and the touch bar yourself in the report?

Copy link
Member Author

@danghai danghai Jun 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take the information from this issue : DIGImend/digimend-kernel-drivers#141. I think it is better you put a comment about new usbhid-dump following all case information that you need.
I am not sure about what you need me figure out myself?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, no need to modify usbhid-dump, just find out what the reports mean exactly :) What I write above is how you can do it, organizationally.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. But I need to totally understand the information in dump file first.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I would recommend experimenting with your own tablet, and reading at least the beginning of the USB HID specification.

PID: "006e"
vendor: Huion
product: Kamvas GT221
image: Huion_Kamvas_GT221
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please crop the picture so that only the tablet is visible (with a bit of white border, perhaps). We're not selling these tablets so we better not include any marketing material in the pictures.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I will fix it

iManufacturer 5 (error)
iProduct 6 (error)
iManufacturer 5 Huion
iProduct 6 Kamvas GT191
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not sure we should overwrite this. Have you got an lsusb output for one of these tablets which has these strings?

PID: "006e"
vendor: Huion
product: Kamvas GT191
image: Huion_Kamvas_GT191
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you can find a basic image of this tablet, without any measurements overlaid? Just a photo?

iManufacturer 5 (error)
iProduct 6 (error)
iManufacturer 5 Huion
iProduct 6 Inspiroy Q11K
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, I don't think we should touch these. We need to know what the tablet reports exactly.

@danghai
Copy link
Member Author

danghai commented Jun 12, 2018

My editor automatically fixes space issue :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants