Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using a Service Principal for Terraform deployments #1090

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

DrizzlyOwl
Copy link
Collaborator

  • This change modifies how deployments with Terraform are made. Previously we would login to Azure CLI using our own named @edu accounts and apply terraform changes using those accounts, however this is misaligned with our DfE would prefer us to run deployments.
  • Instead, we ought to be using our subscription-specific deployment service principal. This service principal is granted the minimum role assignments that are required to deploy infrastructure.
  • A big advantage to using the service principal approach is that we are able to conditionally deploy role assignments to managed identities which we were previously not able to achieve without intervention from DfE InfraOps. This helps free up bottlenecks in deployments and ensures we can bring up an entire service from cold without any role assignment issues.
  • Another benefit to using our service principal as deployments are not tied to a specific person

@DrizzlyOwl DrizzlyOwl marked this pull request as ready for review June 27, 2024 15:30
@DrizzlyOwl DrizzlyOwl requested a review from Stretch96 as a code owner June 27, 2024 15:30
@DrizzlyOwl DrizzlyOwl enabled auto-merge (squash) June 27, 2024 15:32
@DrizzlyOwl DrizzlyOwl merged commit bbbcc49 into main Jun 27, 2024
1 check passed
@DrizzlyOwl DrizzlyOwl deleted the use-service-principal branch June 27, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants