Time format check answers

[sarahcrack]

Trello card

https://trello.com/c/vSQni4QV/6962-change-time-formats-on-check-answers-page-in-adviser-funnel-on-git

Context

Whilst reviewing the adviser funnel as part of the move to GIT, a few minor improvements were noticed. One of these concerns the time format used on the check answers page (/teacher-training-adviser/sign_up/review_answers) for callback bookings. The time format should be e.g. 5:30pm.

Changes proposed in this pull request

• Minor tweak to AnswerHelper to format times with :govuk_time_with_period.
• When time is 12:00pm or 00:00am, AnswerHelper converts to midday and midnight as per GDS guidance.
• Updated AnswerHelper test.

Guidance to review

• Please double guidance, especially in relation to midday and midnight formatting (see above). This can be removed if not needed.
• Cannot be merged until check is done with CRM to ensure time values passed are not affected.

[sonarcloud]

Quality Gate passed

Issues
12 New issues
10 Accepted issues

Measures
0 Security Hotspots
95.7% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Review app deployed to https://get-into-teaching-app-review-4394.test.teacherservices.cloud