Amends image block component to support an optional title color #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://get-into-teaching-app-review-4374.test.teacherservices.cloud |
|
|
this works perfectly thanks! I've opened up a new branch based on this one to add the component into the right pages, so happy if you want to merge this one |
jenhadfield-dfe
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/Jd9HvLCS/6811-phase-5-repurpose-navigation-component-for-life-as-a-teacher-section
Context
GIT users need to feel inspired to teach and reassured that teaching is a viable career for them
Repurpose the navigation component used on the homepage to be used throughout the pages within the Life as a teacher section
Changes proposed in this pull request
ImageBlockComponentto support an optionaltitle_colorparam. A list of colours can be found inapp/webpacker/styles/headings.scss:148-168(use the color as a string fromheading--highlight-COLOR).Guidance to review