Change date formats on check answers page in adviser funnel - DO NOT MERGE YET!

[sarahcrack]

Trello card

https://trello.com/c/Z6odPjEh/6961-change-date-formats-on-check-answers-page-in-adviser-funnel-on-git

Context

Whilst reviewing the adviser funnel as part of the move to GIT, a few minor improvements were noticed. One of these concerns the date format used on the check answers page (/teacher-training-adviser/sign_up/review_answers) for date of birth and for the callback bookings. The date format should be e.g. 1 January 1990.

Changes proposed in this pull request

Minor tweak to AnswerHelper to format dates with :govuk_zero_pad

Guidance to review

• check visuals meet GDS best practice on check answers page.
• ensure this change only relates to the display on the review answers page; the format of the value passed to CRM should not be changed.

[github-actions]

Review app deployed to https://get-into-teaching-app-review-4373.test.teacherservices.cloud

[sarahcrack]

N.B. need to check whether this change to the AnswerHelper affects the passing of date values to CRM.

[sonarcloud]

Quality Gate passed

Issues
12 New issues
10 Accepted issues

Measures
0 Security Hotspots
95.7% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud