Merge pull request #1467 from DFE-Digital/prevent-duplicate-degree-su… #3575
martyn-wAnnotations
10 warnings
|
sonarcloud:
GetIntoTeachingApi/Auth/ApiClientSchemaOptions.cs#L5
Remove this empty class, write its code or make it an "interface". (https://rules.sonarsource.com/csharp/RSPEC-2094)
|
|
sonarcloud:
GetIntoTeachingApi/Attributes/PrivateShortTermResponseCacheAttribute.cs#L5
Specify AttributeUsage on 'PrivateShortTermResponseCacheAttribute' to improve readability, even though it inherits it from its base type. (https://rules.sonarsource.com/csharp/RSPEC-3993)
|
|
sonarcloud:
GetIntoTeachingApi/Jobs/LocationSyncJob.cs#L24
Refactor your code not to use hardcoded absolute paths or URIs. (https://rules.sonarsource.com/csharp/RSPEC-1075)
|
|
sonarcloud:
GetIntoTeachingApi/Services/CrmService.cs#L29
Remove this unread private field '_env' or refactor the code to use its value. (https://rules.sonarsource.com/csharp/RSPEC-4487)
|
|
sonarcloud:
GetIntoTeachingApi/Services/CrmService.cs#L87
Define a constant instead of using this literal 'dfe_starttime' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
sonarcloud:
GetIntoTeachingApi/Services/CrmService.cs#L185
Define a constant instead of using this literal 'contact' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
sonarcloud:
GetIntoTeachingApi/Services/RedisService.cs#L14
Remove the field '_options' and declare it as a local variable in the relevant methods. (https://rules.sonarsource.com/csharp/RSPEC-1450)
|
|
sonarcloud:
GetIntoTeachingApi/Services/Store.cs#L26
Remove this unread private field '_env' or refactor the code to use its value. (https://rules.sonarsource.com/csharp/RSPEC-4487)
|
|
sonarcloud:
GetIntoTeachingApi/Migrations/20200810073833_UpdateEventSchema.cs#L11
Define a constant instead of using this literal 'TeachingEventBuildings' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
sonarcloud:
GetIntoTeachingApi/Migrations/20200810073833_UpdateEventSchema.cs#L15
Define a constant instead of using this literal 'TeachingEvents' 20 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|