Skip to content

Allow registering without a phone number #3077

Allow registering without a phone number

Allow registering without a phone number #3077

GitHub Actions / Unit test results failed Sep 28, 2023 in 1s

Unit test results ❌

Tests failed

❌ dotnet-authserver/tests/TeacherIdentity.AuthServer.Tests/TestResults/_fv-az305-151_2023-09-28_13_19_17.trx

1450 tests were completed in 41s with 1449 passed, 1 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TeacherIdentity.AuthServer.Tests.AuthenticationStateTests 15✅ 47ms
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.DateOfBirth.ConfirmTests 5✅ 7s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.DateOfBirth.DateOfBirthTests 9✅ 7s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.Email.ConfirmTests 10✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.Email.EmailTests 12✅ 11s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.Email.ResendTests 11✅ 11s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.IndexTests 14✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.Name.ConfirmTests 8✅ 159ms
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.Name.NameTests 10✅ 9s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.OfficialDateOfBirth.ConfirmTests 8✅ 9s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.OfficialDateOfBirth.DetailsTests 10✅ 7s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.OfficialDateOfBirth.EvidenceTests 11✅ 9s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.OfficialDateOfBirth.OfficialDateOfBirthTests 4✅ 6s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.OfficialName.ConfirmTests 10✅ 9s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.OfficialName.DetailsTests 13✅ 9s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.OfficialName.EvidenceTests 15✅ 10s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.OfficialName.OfficialNameTests 3✅ 4s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.OfficialName.PreferredNameTests 8✅ 8s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.Phone.ConfirmTests 10✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.Phone.PhoneTests 9✅ 10s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.Phone.ResendTests 8✅ 9s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.PreferredName.ConfirmTests 4✅ 7s
TeacherIdentity.AuthServer.Tests.EndpointTests.Account.PreferredName.PreferredNameTests 7✅ 6s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.AddClientTests 7✅ 7s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.AddStaffUserTests 7✅ 6s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.AddUserImportTests 10✅ 8s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.AddWebHookTests 6✅ 7s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.AssignTrn.ConfirmTests 21✅ 434ms
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.AssignTrn.IndexTests 18✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.AssignTrn.RemoveTests 11✅ 11s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.ClientsTests 3✅ 5s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.EditClientTests 8✅ 11s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.EditStaffUserTests 9✅ 10s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.EditUserEmailTests 14✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.EditUserMobileNumberTests 13✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.EditUserNameTests 21✅ 14s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.EditWebHookTests 14✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.GenerateTrnTokenTests 8✅ 8s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.MergeUser.ChooseTrnTests 11✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.MergeUser.ConfirmTests 11✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.MergeUser.SelectUserTests 10✅ 10s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.StaffTests 3✅ 4s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.UserImportsTests 3✅ 6s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.UserImportTests 5✅ 7s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.UsersTests 42✅ 2s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.UserTests 7✅ 10s
TeacherIdentity.AuthServer.Tests.EndpointTests.Admin.WebHooksTests 3✅ 4s
TeacherIdentity.AuthServer.Tests.EndpointTests.Api.SetJourneyTrnLookupStateTests 14✅ 9s
TeacherIdentity.AuthServer.Tests.EndpointTests.Api.V1.TrnTokens.CreateTrnTokenTests 6✅ 5s
TeacherIdentity.AuthServer.Tests.EndpointTests.Api.V1.Users.GetAllUsersTests 13✅ 261ms
TeacherIdentity.AuthServer.Tests.EndpointTests.Api.V1.Users.GetUserDetailTests 8✅ 11s
TeacherIdentity.AuthServer.Tests.EndpointTests.Api.V1.Users.SetTeacherTrnTests 14✅ 13s
TeacherIdentity.AuthServer.Tests.EndpointTests.Api.V1.Users.UpdateUserTests 11✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.Oidc.AuthorizeTests 25✅ 329ms
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.CompleteTests 19✅ 14s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Elevate.CheckAnswersTests 11✅ 212ms
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.EmailConfirmationTests 27✅ 555ms
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.EmailTests 20✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.LandingTests 5✅ 5s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.AccountExistsTests 15✅ 11s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.CheckAnswersTests 19✅ 451ms
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.DateOfBirthPageTests 19✅ 11s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.EmailConfirmationTests 20✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.EmailExistsTests 7✅ 8s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.EmailTests 16✅ 10s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.ExistingAccountEmailConfirmationTests 20✅ 7s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.ExistingAccountPhoneConfirmationTests 22✅ 7s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.ExistingAccountPhoneTests 14✅ 5s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.HasNiNumberPageTests 20✅ 10s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.HasQtsPageTests 22✅ 11s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.HasTrnPageTests 20✅ 10s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.InstitutionEmailTests 17✅ 11s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.IttProviderTests 18✅ 10s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.NameTests 18✅ 10s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.NiNumberPageTests 19✅ 9s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.PhoneConfirmationTests 21✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.PhoneExistsTests 7✅ 7s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.PhoneTests 16✅ 1❌ 9s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.PreferredNamePageTests 15✅ 9s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.ResendEmailConfirmationTests 19✅ 11s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.ResendExistingAccountEmailTests 13✅ 5s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.ResendExistingAccountPhoneTests 15✅ 6s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.ResendPhoneConfirmationTests 17✅ 10s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.TrnPageTests 20✅ 10s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.ResendEmailConfirmationTests 25✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.ResendTrnOwnerEmailConfirmationTests 10✅ 10s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.TrnInUseChooseEmailTests 21✅ 12s
TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.TrnInUseTests 24✅ 12s
TeacherIdentity.AuthServer.Tests.HelperTests.NationalInsuranceNumberHelperTests 8✅ 14ms
TeacherIdentity.AuthServer.Tests.Jobs.PopulatePreferredNameJobTests 3✅ 59ms
TeacherIdentity.AuthServer.Tests.Jobs.RefreshEstablishmentDomainsJobTests 3✅ 5s
TeacherIdentity.AuthServer.Tests.Jobs.SyncNamesWithDqtJobTests 2✅ 51ms
TeacherIdentity.AuthServer.Tests.JourneyTests.TrnLookupHelperTests 21✅ 282ms
TeacherIdentity.AuthServer.Tests.ModelTests.ApplicationTests 10✅ 1ms
TeacherIdentity.AuthServer.Tests.ModelTests.EmailAddressTests 94✅ 11ms
TeacherIdentity.AuthServer.Tests.ModelTests.MobileNumberTests 28✅ 9ms
TeacherIdentity.AuthServer.Tests.Services.PublishEventsBackgroundServiceTests 3✅ 76ms
TeacherIdentity.AuthServer.Tests.Services.RedactorTests 9✅ 2ms
TeacherIdentity.AuthServer.Tests.Services.UserImportProcessorTests 25✅ 504ms
TeacherIdentity.AuthServer.Tests.Services.UserVerificationServiceTests 14✅ 11s
TeacherIdentity.AuthServer.Tests.UserClaimHelperTests 21✅ 13s
TeacherIdentity.AuthServer.Tests.UserRequirementsExtensionsTests 10✅ 13ms
TeacherIdentity.AuthServer.Tests.WebHooks.WebHooksEndToEndTests 37✅ 1s

❌ TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.PhoneTests

✅ Get_EmailNotVerified_RedirectsToEmailConfirmation
✅ Get_InvalidAuthenticationStateProvided_ReturnsBadRequest
✅ Get_JourneyHasExpired_RendersErrorPage
✅ Get_JourneyIsAlreadyCompleted_RedirectsToPostSignInUrl
✅ Get_MissingAuthenticationStateProvided_ReturnsBadRequest
✅ Get_ValidRequest_RendersContent
✅ Post_EmailNotVerified_RedirectsToEmailConfirmation
✅ Post_EmptyMobileNumber_ReturnsError
✅ Post_InvalidAuthenticationStateProvided_ReturnsBadRequest
✅ Post_InvalidMobileNumber_ReturnsError
✅ Post_JourneyHasExpired_RendersErrorPage
✅ Post_JourneyIsAlreadyCompleted_RedirectsToPostSignInUrl
✅ Post_NoAuthenticationStateProvided_ReturnsBadRequest
✅ Post_NotificationServiceInvalidMobileNumber_ReturnsError
✅ Post_ValidMobileNumber_SetsMobileNumberOnAuthenticationStateGeneratesPin
✅ Post_ValidMobileNumberWithBlockedClient_ReturnsTooManyRequestsStatusCode
❌ PostContinueWithout_SetsContinueWithoutPhoneNumberOnAuthenticationStateAndRedirects
	Assert.Equal() Failure
	Expected: 302
	Actual:   400

Annotations

Check failure on line 207 in dotnet-authserver/tests/TeacherIdentity.AuthServer.Tests/EndpointTests/SignIn/Register/PhoneTests.cs

See this annotation in the file changed.

@github-actions github-actions / Unit test results

TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.PhoneTests ► PostContinueWithout_SetsContinueWithoutPhoneNumberOnAuthenticationStateAndRedirects

Failed test found in:
  dotnet-authserver/tests/TeacherIdentity.AuthServer.Tests/TestResults/_fv-az305-151_2023-09-28_13_19_17.trx
Error:
  Assert.Equal() Failure
  Expected: 302
  Actual:   400
Raw output
Assert.Equal() Failure
Expected: 302
Actual:   400
   at TeacherIdentity.AuthServer.Tests.EndpointTests.SignIn.Register.PhoneTests.PostContinueWithout_SetsContinueWithoutPhoneNumberOnAuthenticationStateAndRedirects() in /home/runner/work/get-an-identity/get-an-identity/dotnet-authserver/tests/TeacherIdentity.AuthServer.Tests/EndpointTests/SignIn/Register/PhoneTests.cs:line 207