Remove image path from favicon link tags #1161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpattinson
force-pushed
the
Remove-image_path-from-favicon-link-tags
branch
6 times, most recently
from
fb5dff1 to
dd2544d
Compare
peteryates
reviewed
Dec 30, 2024
app/views/layouts/base.html.erb
Outdated
| @@ -11,12 +11,12 @@ | |||
|
|
|||
| <link rel="shortcut icon" sizes="16x16 32x32 48x48" href="favicon.ico" type="image/x-icon"> | |||
There was a problem hiding this comment.
Suggested change
| <link rel="shortcut icon" sizes="16x16 32x32 48x48" href="favicon.ico" type="image/x-icon"> |
peteryates
reviewed
Dec 30, 2024
app/views/layouts/base.html.erb
Outdated
Comment on lines
14
to
16
| <%= favicon_link_tag 'favicon.ico', type: nil, sizes: "48x48" %> | ||
| <%= favicon_link_tag 'favicon.svg', type: nil, sizes: "48x48" %> | ||
| <%= favicon_link_tag 'govuk-icon-mask.svg', rel: 'mask-icon', color: "#0b0c0c", type: nil %> | ||
| <%= favicon_link_tag 'govuk-icon-180.png', rel: 'apple-touch-icon', type: nil %> |
There was a problem hiding this comment.
Suggested change
| <%= favicon_link_tag 'favicon.ico', type: nil, sizes: "48x48" %> | |
| <%= favicon_link_tag 'favicon.svg', type: nil, sizes: "48x48" %> | |
| <%= favicon_link_tag 'govuk-icon-mask.svg', rel: 'mask-icon', color: "#0b0c0c", type: nil %> | |
| <%= favicon_link_tag 'govuk-icon-180.png', rel: 'apple-touch-icon', type: nil %> | |
| <%= favicon_link_tag '/favicon.ico', type: nil, sizes: "48x48" %> | |
| <%= favicon_link_tag '/favicon.svg', type: nil, sizes: "48x48" %> | |
| <%= favicon_link_tag '/govuk-icon-mask.svg', rel: 'mask-icon', color: "#0b0c0c", type: nil %> | |
| <%= favicon_link_tag '/govuk-icon-180.png', rel: 'apple-touch-icon', type: nil %> |
richardpattinson
force-pushed
the
Remove-image_path-from-favicon-link-tags
branch
3 times, most recently
from
317181d to
4600204
Compare
richardpattinson
force-pushed
the
Remove-image_path-from-favicon-link-tags
branch
from
4600204 to
01480d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The image tag helper was causing incorrect path loading for assets.
Changes proposed in this pull request
Guidance to review
Link to Trello card
Checklist