add unsubscribe functionality

app/controllers/unsubscribe_controller.rb

@@ -0,0 +1,30 @@
+class UnsubscribeController < ApplicationController
+  def show
+    @form = Unsubscribe::ConfirmationForm.new(form_params)
+
+    if @form.reminder.nil?
+      render "subscription_not_found"
+    end
+  end
+
+  def create
+    @form = Unsubscribe::ConfirmationForm.new(form_params)
+
+    if @form.reminder.nil?
+      head :bad_request
+    else
+      @form.reminder.destroy
+    end
+  end
+
+  private
+
+  def form_params
+    params.permit([:id])
+  end
+
+  def current_journey_routing_name
+    params[:journey]
+  end
+  helper_method :current_journey_routing_name
+end

app/forms/unsubscribe/confirmation_form.rb

@@ -0,0 +1,12 @@
+module Unsubscribe
+  class ConfirmationForm
+    include ActiveModel::Model
+    include ActiveModel::Attributes
+
+    attribute :id, :string
+
+    def reminder
+      @reminder ||= Reminder.find_by(id:)
+    end
+  end
+end

app/mailers/reminder_mailer.rb

@@ -19,7 +19,13 @@ def email_verification(reminder, one_time_password, journey_name)
       journey_name:
     }
 
-    send_mail(OTP_EMAIL_NOTIFY_TEMPLATE_ID, personalisation)
+    template_mail(
+      OTP_EMAIL_NOTIFY_TEMPLATE_ID,
+      to: @reminder.email_address,
+      reply_to_id: GENERIC_NOTIFY_REPLY_TO_ID,
+      subject: @subject,
+      personalisation:
+    )
   end
 
   def reminder_set(reminder)
@@ -29,10 +35,17 @@ def reminder_set(reminder)
     personalisation = {
       first_name: extract_first_name(@reminder.full_name),
       support_email_address: support_email_address,
-      next_application_window: @reminder.send_year
+      next_application_window: @reminder.send_year,
+      unsubscribe_url: unsubscribe_url(reminder:)
     }
 
-    send_mail(REMINDER_SET_NOTIFY_TEMPLATE_ID, personalisation)
+    template_mail(
+      REMINDER_SET_NOTIFY_TEMPLATE_ID,
+      to: @reminder.email_address,
+      reply_to_id: GENERIC_NOTIFY_REPLY_TO_ID,
+      subject: @subject,
+      personalisation:
+    )
   end
 
   # TODO: This template only accommodates LUP/ECP claims currently. Needs to
@@ -47,22 +60,22 @@ def reminder(reminder)
       support_email_address: support_email_address
     }
 
-    send_mail(REMINDER_APPLICATION_WINDOW_OPEN_NOTIFY_TEMPLATE_ID, personalisation)
-  end
-
-  private
-
-  def extract_first_name(fullname)
-    (fullname || "").split(" ").first
-  end
-
-  def send_mail(template_id, personalisation)
     template_mail(
-      template_id,
+      REMINDER_APPLICATION_WINDOW_OPEN_NOTIFY_TEMPLATE_ID,
       to: @reminder.email_address,
       reply_to_id: GENERIC_NOTIFY_REPLY_TO_ID,
       subject: @subject,
       personalisation:
     )
   end
+
+  private
+
+  def unsubscribe_url(reminder:)
+    "https://#{ENV["CANONICAL_HOSTNAME"]}/#{reminder.journey::ROUTING_NAME}/unsubscribe/reminders/#{reminder.id}"
+  end
+
+  def extract_first_name(fullname)
+    (fullname || "").split(" ").first
+  end
 end

app/views/unsubscribe/create.html.erb

@@ -0,0 +1,7 @@
+<%= content_for(:page_title) { "Unsubscribe" } %>
+
+<div class="govuk-grid-row">
+  <div class="govuk-grid-column-two-thirds">
+    <%= govuk_panel(title_text: "Unsubscribe complete") %>
+  </div>
+</div>

app/views/unsubscribe/show.html.erb

@@ -0,0 +1,19 @@
+<%= content_for(:page_title) { "Unsubscribe" } %>
+
+<div class="govuk-grid-row">
+  <div class="govuk-grid-column-two-thirds">
+    <%= form_with model: @form,
+      url: unsubscribe_index_path,
+      scope: "",
+      builder: GOVUKDesignSystemFormBuilder::FormBuilder do |f| %>
+
+      <%= f.hidden_field :id %>
+
+      <h1 class="govuk-heading-l">
+        Are you sure you wish to unsubscribe from your reminder?
+      </h1>
+
+      <%= f.govuk_submit "Unsubscribe" %>
+    <% end %>
+  </div>
+</div>

app/views/unsubscribe/subscription_not_found.html.erb

@@ -0,0 +1,11 @@
+<div class="govuk-grid-row">
+  <div class="govuk-grid-column-two-thirds">
+    <h1 class="govuk-heading-l">
+      Subscription not found
+    </h1>
+
+    <p class="govuk-body">
+      Your subscription could not be found. Either you have already unsubscribed or please ensure you have copied your unsubscribe link correctly.
+    </p>
+  </div>
+</div>

config/environments/development.rb

@@ -60,8 +60,7 @@
   # Highlight code that triggered database queries in logs.
   config.active_record.verbose_query_logs = true
 
-  # Raise an exception if parameters that are not explicitly permitted are found
-  config.action_controller.action_on_unpermitted_parameters = :raise
+  config.action_controller.action_on_unpermitted_parameters = :log
 
   # Debug mode disables concatenation and preprocessing of assets.
   # This option may cause significant delays in view rendering with a large

config/environments/test.rb

@@ -33,8 +33,7 @@
   # Disable request forgery protection in test environment.
   config.action_controller.allow_forgery_protection = false
 
-  # Raise an exception if parameters that are not explicitly permitted are found
-  config.action_controller.action_on_unpermitted_parameters = :raise
+  config.action_controller.action_on_unpermitted_parameters = :log
 
   config.action_mailer.perform_caching = false
 

config/routes.rb

@@ -65,6 +65,11 @@ def matches?(request)
       end
     end
 
+    resources :unsubscribe,
+      path: "/unsubscribe/:resource_class",
+      constraints: {resource_class: /reminders/},
+      only: [:create, :show]
+
     scope constraints: {journey: /further-education-payments|additional-payments/} do
       resources :reminders,
         only: [:show, :update],

spec/features/unsubscribe_spec.rb

@@ -0,0 +1,26 @@
+require "rails_helper"
+
+RSpec.feature "unsubscribe from reminders" do
+  let(:reminder) do
+    create(
+      :reminder,
+      journey_class: Journeys::FurtherEducationPayments.to_s
+    )
+  end
+
+  scenario "happy path" do
+    visit "/#{reminder.journey::ROUTING_NAME}/unsubscribe/reminders/#{reminder.id}"
+    expect(page).to have_content "Are you sure you wish to unsub"
+
+    expect {
+      click_button("Unsubscribe")
+    }.to change(Reminder, :count).by(-1)
+
+    expect(page).to have_content "Unsubscribe complete"
+  end
+
+  scenario "when reminder does not exist" do
+    visit "/#{reminder.journey::ROUTING_NAME}/unsubscribe/reminders/idonotexist"
+    expect(page).to have_content "Subscription not found"
+  end
+end

spec/forms/current_school_form_spec.rb

@@ -19,14 +19,6 @@
       )
     end
 
-    context "unpermitted claim param" do
-      let(:params) { ActionController::Parameters.new({slug: slug, claim: {nonsense_id: 1}}) }
-
-      it "raises an error" do
-        expect { form }.to raise_error ActionController::UnpermittedParameters
-      end
-    end
-
     describe "#schools" do
       context "new form" do
         let(:params) { ActionController::Parameters.new({slug: slug, claim: {}}) }

spec/forms/employed_directly_form_spec.rb

@@ -17,14 +17,6 @@
     )
   end
 
-  context "unpermitted claim param" do
-    let(:params) { ActionController::Parameters.new({slug:, claim: {random_param: 1}}) }
-
-    it "raises an error" do
-      expect { form }.to raise_error ActionController::UnpermittedParameters
-    end
-  end
-
   describe "#employed_directly" do
     let(:params) { ActionController::Parameters.new({slug:, claim: {}}) }
 

spec/forms/form_spec.rb

@@ -48,14 +48,6 @@ def initialize(journey_session)
   let(:claim_params) { {first_name: "test-name"} }
 
   describe "#initialize" do
-    context "with unpermitted params" do
-      let(:claim_params) { {unpermitted: "my-name"} }
-
-      it "raises an error" do
-        expect { form }.to raise_error(ActionController::UnpermittedParameters)
-      end
-    end
-
     context "with valid params" do
       let(:claim_params) { {first_name: "my-name"} }
 
@@ -218,13 +210,5 @@ def initialize(journey_session)
         expect(form.permitted_params).to eql(ActionController::Parameters.new(claim_params.stringify_keys).permit!)
       end
     end
-
-    context "with params containing attributes not defined on the form" do
-      let(:claim_params) { super().merge(unpermitted_attribute: "test-value") }
-
-      it "raises an error" do
-        expect { form.permitted_params }.to raise_error(ActionController::UnpermittedParameters)
-      end
-    end
   end
 end

spec/forms/gender_form_spec.rb

@@ -25,14 +25,6 @@
       )
     end
 
-    context "unpermitted claim param" do
-      let(:params) { ActionController::Parameters.new({slug: slug, claim: {nonsense_id: 1}}) }
-
-      it "raises an error" do
-        expect { form }.to raise_error ActionController::UnpermittedParameters
-      end
-    end
-
     describe "#payroll_gender" do
       let(:params) { ActionController::Parameters.new({slug: slug, claim: {}}) }
 

spec/forms/journeys/additional_payments_for_teaching/entire_term_contract_form_spec.rb

@@ -17,14 +17,6 @@
     )
   end
 
-  context "unpermitted claim param" do
-    let(:params) { ActionController::Parameters.new({slug:, claim: {random_param: 1}}) }
-
-    it "raises an error" do
-      expect { form }.to raise_error ActionController::UnpermittedParameters
-    end
-  end
-
   describe "#has_entire_term_contract" do
     let(:params) { ActionController::Parameters.new({slug:, claim: {}}) }
 

spec/forms/journeys/additional_payments_for_teaching/induction_completed_form_spec.rb

@@ -17,14 +17,6 @@
     )
   end
 
-  context "unpermitted claim param" do
-    let(:params) { ActionController::Parameters.new({slug: slug, claim: {nonsense_id: 1}}) }
-
-    it "raises an error" do
-      expect { form }.to raise_error ActionController::UnpermittedParameters
-    end
-  end
-
   describe "#save" do
     let(:params) { ActionController::Parameters.new({slug: slug, claim: {induction_completed: true}}) }
 

spec/forms/journeys/additional_payments_for_teaching/itt_academic_year_form_spec.rb

@@ -31,14 +31,6 @@
     )
   end
 
-  context "unpermitted claim param" do
-    let(:params) { ActionController::Parameters.new({slug: slug, claim: {nonsense_id: 1}}) }
-
-    it "raises an error" do
-      expect { form }.to raise_error ActionController::UnpermittedParameters
-    end
-  end
-
   describe "#itt_academic_year" do
     let(:params) { ActionController::Parameters.new({slug: slug, claim: {}}) }
 

spec/forms/journeys/teacher_student_loan_reimbursement/claim_school_form_spec.rb

@@ -34,14 +34,6 @@
     )
   end
 
-  context "unpermitted claim param" do
-    let(:params) { ActionController::Parameters.new({slug: slug, claim: {nonsense_id: 1}}) }
-
-    it "raises an error" do
-      expect { form }.to raise_error ActionController::UnpermittedParameters
-    end
-  end
-
   describe "#schools" do
     context "new form" do
       let(:params) { ActionController::Parameters.new({slug: slug, claim: {}}) }

spec/forms/personal_details_form_spec.rb

@@ -30,16 +30,6 @@
       )
     end
 
-    context "unpermitted claim param" do
-      let(:params) { {nonsense_id: 1} }
-      let(:logged_in_with_tid) { nil }
-      let(:teacher_id_user_info) { {} }
-
-      it "raises an error" do
-        expect { form }.to raise_error ActionController::UnpermittedParameters
-      end
-    end
-
     describe "#show_name_section?" do
       context "when not logged_in_with_tid" do
         let(:logged_in_with_tid) { nil }

spec/forms/poor_performance_form_spec.rb

@@ -11,14 +11,6 @@
 
   it { expect(form).to be_a(Form) }
 
-  context "with unpermitted params" do
-    let(:claim_params) { {unpermitted_param: ""} }
-
-    it "raises an error" do
-      expect { form }.to raise_error ActionController::UnpermittedParameters
-    end
-  end
-
   describe "validations" do
     context "subject_to_formal_performance_action" do
       it "cannot be nil" do

spec/forms/provide_mobile_number_form_spec.rb

@@ -29,16 +29,6 @@
       )
     end
 
-    context "unpermitted claim param" do
-      let(:provide_mobile_number) { nil }
-
-      let(:params) { ActionController::Parameters.new({slug: slug, claim: {nonsense_id: 1}}) }
-
-      it "raises an error" do
-        expect { form }.to raise_error ActionController::UnpermittedParameters
-      end
-    end
-
     describe "validations" do
       let(:provide_mobile_number) { nil }