Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - 2 Dec R1 #476

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Release - 2 Dec R1 #476

wants to merge 4 commits into from

Conversation

sam-c-dfe
Copy link
Collaborator

Description

Please include a summary of the changes.

Ticket number (if applicable)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

Please include screenshots if applicable.

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sam-c-dfe sam-c-dfe changed the title Fix issues flagged by Sonar (#475) Release - 2 Dec R1 Dec 2, 2024
* Updated packages to latest version and updated unit test as part of the OwaspHeaders.Core update which changed the default value

* Update E2E tests
* Updated packages and fixed breaking changes

* Added null check for header value
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Mock 100% 98%
Dfe.EarlyYearsQualification.Content 98% 90%
Dfe.EarlyYearsQualification.Web 96% 90%
Summary 97% (4119 / 4227) 91% (678 / 746)

Minimum allowed line rate is 90%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants