Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues flagged by Sonar #475

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

RobertGHippo
Copy link
Collaborator

Description

Fixed issues left behind in file that is really only to show how browser tests can work.

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Mock 100% 98%
Dfe.EarlyYearsQualification.Content 98% 90%
Dfe.EarlyYearsQualification.Web 96% 90%
Summary 97% (4120 / 4228) 91% (678 / 746)

Minimum allowed line rate is 90%

@sam-c-dfe sam-c-dfe changed the base branch from main to release/02-Dec-24-R1 December 2, 2024 14:36
@sam-c-dfe sam-c-dfe merged commit bfa2e70 into release/02-Dec-24-R1 Dec 2, 2024
4 checks passed
@sam-c-dfe sam-c-dfe deleted the feature/fix-sonar-issues branch December 2, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants