Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright tests spike #432

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Playwright tests spike #432

wants to merge 4 commits into from
+246 −2

Conversation

DanielClarkeEducation
Copy link
Contributor

@DanielClarkeEducation DanielClarkeEducation commented Oct 22, 2024 •
edited
Loading

Description

  • PR for the spike around switching E2E testing from cypress to playwright to get safari coverage

Ticket number (if applicable)

https://dfedigital.atlassian.net.mcas.ms/browse/EYQB-692

How Has This Been Tested?

CI pipeline passing, can view edge tests running

Screenshots

Please include screenshots if applicable.

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Base automatically changed from release/17-Oct-24-R1 to main October 24, 2024 13:09
@DanielClarkeEducation DanielClarkeEducation marked this pull request as ready for review October 29, 2024 09:24
@DanielClarkeEducation DanielClarkeEducation changed the title added edge into our E2E tests Playwright tests spike Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Mock 100% 98% ✔
Dfe.EarlyYearsQualification.Content 98% 90% ✔
Dfe.EarlyYearsQualification.Web 97% 91% ✔
Summary 98% (3871 / 3957) 91% (631 / 692) ✔

Minimum allowed line rate is 90%

sam-c-dfe
sam-c-dfe previously approved these changes Nov 18, 2024
View reviewed changes
@sam-c-dfe sam-c-dfe self-requested a review November 20, 2024 12:00
@sam-c-dfe sam-c-dfe dismissed their stale review November 20, 2024 12:01

Not sure if this branch is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-c-dfe sam-c-dfe Awaiting requested review from sam-c-dfe

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielClarkeEducation @sam-c-dfe