Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/eyqb-486-level-7-page #292

Merged
merged 8 commits into from
Aug 6, 2024
Merged

feature/eyqb-486-level-7-page #292

merged 8 commits into from
Aug 6, 2024

Conversation

RobertGHippo
Copy link
Collaborator

@RobertGHippo RobertGHippo commented Aug 6, 2024 •
edited
Loading

Description

New static page for advice about qualifications at Level 7.

Ticket number (if applicable)

EYQB-486

How Has This Been Tested?

Works locally, PR contains appropriate new unit tests and end-to-end tests.

Screenshots

image

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Content 91% 90% ✔
Dfe.EarlyYearsQualification.Web 97% 91% ✔
Dfe.EarlyYearsQualification.Mock 100% 100% ✔
Summary 96% (2743 / 2872) 91% (409 / 448) ✔

Minimum allowed line rate is 90%

@RobertGHippo RobertGHippo marked this pull request as ready for review August 6, 2024 14:30
@RobertGHippo RobertGHippo merged commit db82d3d into main Aug 6, 2024
4 checks passed
@RobertGHippo RobertGHippo deleted the feature/eyqb-486-level-7-page branch August 6, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-c-dfe sam-c-dfe sam-c-dfe approved these changes

@DanielClarkeEducation DanielClarkeEducation Awaiting requested review from DanielClarkeEducation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertGHippo @sam-c-dfe