Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/results page print button #286

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Feature/results page print button #286

merged 4 commits into from
Aug 5, 2024

Conversation

DanielClarkeEducation
Copy link
Contributor

Description

Please include a summary of the changes.

Ticket number (if applicable)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

Please include screenshots if applicable.

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@DanielClarkeEducation DanielClarkeEducation marked this pull request as ready for review August 5, 2024 09:20
sam-c-dfe
sam-c-dfe previously approved these changes Aug 5, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Content 91% 90% ✔
Dfe.EarlyYearsQualification.Web 97% 91% ✔
Dfe.EarlyYearsQualification.Mock 100% 100% ✔
Summary 95% (2660 / 2788) 91% (387 / 426) ✔

Minimum allowed line rate is 90%

@sam-c-dfe sam-c-dfe merged commit 08eee12 into main Aug 5, 2024
4 checks passed
@sam-c-dfe sam-c-dfe deleted the feature/results-page-print-button branch August 5, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertGHippo RobertGHippo RobertGHippo approved these changes

@sam-c-dfe sam-c-dfe sam-c-dfe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielClarkeEducation @sam-c-dfe @RobertGHippo