Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/your results page #274

Merged
merged 20 commits into from
Jul 30, 2024
Merged

Feature/your results page #274

merged 20 commits into from
Jul 30, 2024

Conversation

sam-c-dfe
Copy link
Collaborator

@sam-c-dfe sam-c-dfe commented Jul 29, 2024 •
edited
Loading

Description

Please include a summary of the changes.

Ticket number (if applicable) - EYQB-366

How Has This Been Tested?

Running locally, unit tests and e2e tests

Screenshots

image

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

sam-c-dfe and others added 12 commits July 29, 2024 10:51
@sam-c-dfe
Extended existing qualification details checks and added ids to page …
1f976a2 
…elements
@DanielClarkeEducation
Most of the unit tests for the qualification details controller - onl…
186a16f 
…y a few more until coverage is satisfactory
@sam-c-dfe
Added additional e2e test to validate the ratio order
8831b7e
@sam-c-dfe
Added in additional test to cover a user who answered an additional r…
87b9e31 
…equirement question incorrectly
@sam-c-dfe
Fixed broken unit test
b90a6c7
@DanielClarkeEducation
refactor of the ratio checking method + unit test for all ratios bein…
3dd7018 
…g found
@DanielClarkeEducation
removed unused fields from qualification details view model
3992dce
@sam-c-dfe
Refactored the validate additional questions section out into a new m…
9a25311 
…ethod
@sam-c-dfe
Merge branch 'main' into feature/your-results-page
fb4331b
@sam-c-dfe
Added aria-label to the password field
5f1cb15
@sam-c-dfe
Created new Ratio Requirement constants and updated code to use them
8c89083
@sam-c-dfe
Added additional unit test to up code coverage
14eaa9e
@sam-c-dfe sam-c-dfe marked this pull request as ready for review July 29, 2024 14:12
@sam-c-dfe sam-c-dfe requested a review from RobertGHippo July 30, 2024 07:32
@github-actions GitHub Actions
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Web 97% 89% ✔
Dfe.EarlyYearsQualification.Content 91% 91% ✔
Dfe.EarlyYearsQualification.Mock 100% 100% ✔
Summary 96% (2567 / 2684) 90% (371 / 410) ✔

Minimum allowed line rate is 90%

@sam-c-dfe sam-c-dfe merged commit 4ee5b3d into main Jul 30, 2024
3 checks passed
@sam-c-dfe sam-c-dfe deleted the feature/your-results-page branch July 30, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertGHippo RobertGHippo RobertGHippo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-c-dfe @RobertGHippo @DanielClarkeEducation