Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/unit-test-action #246

Merged
merged 3 commits into from
Jul 18, 2024
Merged

fix/unit-test-action #246

merged 3 commits into from
Jul 18, 2024

Conversation

RobertGHippo
Copy link
Collaborator

@RobertGHippo RobertGHippo commented Jul 17, 2024 •
edited
Loading

Description

Fix: make it so a failing unit test causes the workflow to fail the PR.

@github-actions GitHub Actions
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Content 90% 91% ✔
Dfe.EarlyYearsQualification.Web 96% 88% ✔
Dfe.EarlyYearsQualification.Mock 100% 100% ✔
Summary 95% (2103 / 2216) 90% (297 / 330) ✔

Minimum allowed line rate is 90%

@sam-c-dfe sam-c-dfe merged commit 81e19c2 into main Jul 18, 2024
3 checks passed
@sam-c-dfe sam-c-dfe deleted the fix/unit-test-action branch July 18, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-c-dfe sam-c-dfe sam-c-dfe approved these changes

@DanielClarkeEducation DanielClarkeEducation Awaiting requested review from DanielClarkeEducation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertGHippo @sam-c-dfe