Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Scotland, Wales and NI advice pages #243

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

DanielClarkeEducation
Copy link
Contributor

@DanielClarkeEducation DanielClarkeEducation commented Jul 17, 2024

Description

  • Added new Scotland, Wales and Northern Ireland static advice pages
  • Hooked them up to the where qual was awarded page
  • Added unit and E2E tests

Ticket number (if applicable)

https://dfedigital.atlassian.net/browse/EYQB-369
https://dfedigital.atlassian.net/browse/EYQB-371
https://dfedigital.atlassian.net/browse/EYQB-372

How Has This Been Tested?

  • Tested manually locally, including back button navigation
  • New and existing tests passing

Screenshots

Please include screenshots if applicable.

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

…ooked them up to the where page + added unit and E2E tests
@DanielClarkeEducation DanielClarkeEducation marked this pull request as ready for review July 17, 2024 14:46
@sam-c-dfe
Copy link
Collaborator

sam-c-dfe commented Jul 17, 2024

Can you add the new urls to the .pa11yci-ubuntu.js file in the accessibility tests project and the urls-to-check.js file in the e2e project please? Rest of the PR looks good to me :-)

@DanielClarkeEducation
Copy link
Contributor Author

Can you add the new urls to the .pa11yci-ubuntu.js file in the accessibility tests project and the urls-to-check.js file in the e2e project please? Rest of the PR looks good to me :-)

Nice spot, done!

@DanielClarkeEducation DanielClarkeEducation force-pushed the feature/country-static-pages branch from a106bcd to 77c1a00 Compare July 17, 2024 15:45
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Content 90% 91%
Dfe.EarlyYearsQualification.Web 97% 88%
Dfe.EarlyYearsQualification.Mock 99% 83%
Summary 95% (2132 / 2251) 89% (306 / 342)

Minimum allowed line rate is 90%

@DanielClarkeEducation DanielClarkeEducation merged commit 52f4167 into main Jul 18, 2024
3 checks passed
@DanielClarkeEducation DanielClarkeEducation deleted the feature/country-static-pages branch July 18, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants