Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/sonar-issues #235

Merged
merged 10 commits into from
Jul 18, 2024
Merged

fix/sonar-issues #235

merged 10 commits into from
Jul 18, 2024

Conversation

RobertGHippo
Copy link
Collaborator

Description

Very minor ReSharper and Sonar issues.

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RobertGHippo RobertGHippo requested a review from sam-c-dfe July 9, 2024 16:37
@RobertGHippo
Don't redirect on invalid model state, just log.
614f757 
Allow for .NET treatment of POSTed empty string.
@RobertGHippo RobertGHippo requested a review from sam-c-dfe July 17, 2024 14:43
sam-c-dfe
sam-c-dfe previously approved these changes Jul 18, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Content 90% 92% ✔
Dfe.EarlyYearsQualification.Web 96% 89% ✔
Dfe.EarlyYearsQualification.Mock 99% 83% ✔
Summary 95% (2134 / 2254) 90% (306 / 340) ✔

Minimum allowed line rate is 90%

@RobertGHippo RobertGHippo merged commit 8b99795 into main Jul 18, 2024
3 checks passed
@RobertGHippo RobertGHippo deleted the fix/sonar-issues branch July 18, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-c-dfe sam-c-dfe sam-c-dfe approved these changes

@DanielClarkeEducation DanielClarkeEducation Awaiting requested review from DanielClarkeEducation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertGHippo @sam-c-dfe