Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit of the Contentful filter changes for the qualification list page. #234

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Initial commit of the Contentful filter changes for the qualification list page. #234

merged 7 commits into from
Jul 9, 2024

Conversation

sam-c-dfe
Copy link
Collaborator

Initial commit of the Contentful filter changes for the qualification list.

Description

Please include a summary of the changes.

Ticket number (if applicable) - EYQB-334

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

Please include screenshots if applicable.

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sam-c-dfe sam-c-dfe marked this pull request as ready for review July 9, 2024 13:23
@sam-c-dfe sam-c-dfe requested a review from RobertGHippo July 9, 2024 13:23
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Web 97% 88% ✔
Dfe.EarlyYearsQualification.Content 86% 88% ❌
Dfe.EarlyYearsQualification.Mock 100% 100% ✔
Summary 93% (2049 / 2194) 88% (295 / 334) ✔

Minimum allowed line rate is 90%

@sam-c-dfe sam-c-dfe merged commit 9a3ea54 into main Jul 9, 2024
3 checks passed
@sam-c-dfe sam-c-dfe deleted the feature/eyqb-334-qualification-list-search branch July 9, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertGHippo RobertGHippo RobertGHippo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sam-c-dfe @RobertGHippo