Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/general-tidy-up #230

Merged
merged 9 commits into from
Jul 4, 2024
Merged

chore/general-tidy-up #230

merged 9 commits into from
Jul 4, 2024

Conversation

RobertGHippo
Copy link
Collaborator

Description

General tidy-up, let ReSharper do its thing and either implement suggestions or disable them with comment.

How Has This Been Tested?

All runs locally and looks OK. Unit tests pass.

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RobertGHippo RobertGHippo requested review from DanielClarkeEducation and sam-c-dfe and removed request for DanielClarkeEducation July 3, 2024 17:13
sam-c-dfe
sam-c-dfe previously approved these changes Jul 4, 2024
View reviewed changes
@RobertGHippo RobertGHippo requested a review from sam-c-dfe July 4, 2024 08:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Web 98% 90% ✔
Dfe.EarlyYearsQualification.Content 85% 86% ❌
Dfe.EarlyYearsQualification.Mock 100% 100% ✔
Summary 94% (1871 / 1993) 88% (253 / 286) ✔

Minimum allowed line rate is 90%

@RobertGHippo RobertGHippo merged commit 05800e1 into main Jul 4, 2024
3 checks passed
@RobertGHippo RobertGHippo deleted the chore/general-tidy-up branch July 4, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-c-dfe sam-c-dfe sam-c-dfe approved these changes

@DanielClarkeEducation DanielClarkeEducation Awaiting requested review from DanielClarkeEducation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertGHippo @sam-c-dfe