Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-added table renderers to gov uk table renderer #225

Merged
merged 3 commits into from
Jul 4, 2024
Merged

re-added table renderers to gov uk table renderer #225

merged 3 commits into from
Jul 4, 2024

Conversation

DanielClarkeEducation
Copy link
Contributor

Description

  • re-added table renderers to gov uk table renderer

Ticket number (if applicable)

How Has This Been Tested?

  • Checked manually locally

Screenshots

Staging currently:
image

This fix:
image

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Web 98% 90% ✔
Dfe.EarlyYearsQualification.Content 85% 86% ❌
Dfe.EarlyYearsQualification.Mock 100% 100% ✔
Summary 94% (1871 / 1997) 88% (253 / 286) ✔

Minimum allowed line rate is 90%

@DanielClarkeEducation DanielClarkeEducation marked this pull request as ready for review July 4, 2024 12:50
@DanielClarkeEducation DanielClarkeEducation merged commit 0b3615c into main Jul 4, 2024
3 checks passed
@DanielClarkeEducation DanielClarkeEducation deleted the fix/contentful-table-renderer branch July 4, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertGHippo RobertGHippo RobertGHippo approved these changes

@sam-c-dfe sam-c-dfe sam-c-dfe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielClarkeEducation @sam-c-dfe @RobertGHippo