Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for back button not sticking to just under the header #224

Closed
wants to merge 5 commits into from
Closed

fix for back button not sticking to just under the header #224

wants to merge 5 commits into from

Conversation

DanielClarkeEducation
Copy link
Contributor

Description

  • Small fix for back button not being in the right place - see screenshots

Ticket number (if applicable)

How Has This Been Tested?

  • manually been through every page and checked

Screenshots

Staging currently:
image

Prototype:
image

This fix:
image

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 2, 2024
View reviewed changes
src/Dfe.EarlyYearsQualification.Web/Views/Questions/Radio.cshtml
</span>
</summary>
<div class="govuk-details__text">
@Html.Raw(Model.AdditionalInformationBody)

Check warning

Code scanning / CodeQL

Cross-site scripting Medium

User-provided value
Loading
flows to here and is written to HTML or JavaScript: Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper.Raw() method.
User-provided value
Loading
flows to here and is written to HTML or JavaScript: Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper.Raw() method.
RobertGHippo
RobertGHippo previously approved these changes Jul 4, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Web 98% 90% ✔
Dfe.EarlyYearsQualification.Content 85% 86% ❌
Dfe.EarlyYearsQualification.Mock 100% 100% ✔
Summary 94% (1871 / 1997) 88% (253 / 286) ✔

Minimum allowed line rate is 90%

@DanielClarkeEducation DanielClarkeEducation marked this pull request as ready for review July 5, 2024 11:12
@sam-c-dfe
Copy link
Collaborator

Closing as fixed under this PR: #232

@sam-c-dfe sam-c-dfe closed this Jul 8, 2024
@DanielClarkeEducation DanielClarkeEducation deleted the fix/back-button-spacing branch July 15, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertGHippo RobertGHippo RobertGHippo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielClarkeEducation @sam-c-dfe @RobertGHippo