Skip to content

Commit

Permalink
renamed method to avoid shorthand
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielClarkeEducation committed Aug 7, 2024
1 parent 610fa6c commit eb308ba
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public async Task<IActionResult> Index(string qualificationId)
}

// If there are not any answers to the questions that are not full and relevant we can continue back to check the ratios.
if (!CheckForAnyNonFAndRAnswers(model.AdditionalRequirementAnswers)) return (true, null);
if (!AnswersIndicateNotFullAndRelevant(model.AdditionalRequirementAnswers)) return (true, null);

// At this point, there will be at least one question answered in a non full and relevant way.
// we mark the ratios as not full and relevant and return.
Expand All @@ -125,7 +125,7 @@ public async Task<IActionResult> Index(string qualificationId)
/// </summary>
/// <param name="additionalRequirementsAnswers">This should come from the pre mapped questions and answers</param>
/// <returns>True if we find any question answered in a non full and relevant way, false if none are found</returns>
private static bool CheckForAnyNonFAndRAnswers(List<AdditionalRequirementAnswerModel> additionalRequirementsAnswers)
private static bool AnswersIndicateNotFullAndRelevant(List<AdditionalRequirementAnswerModel> additionalRequirementsAnswers)
{
return additionalRequirementsAnswers.Any(answer => answer is { AnswerToBeFullAndRelevant: true, Answer: "no" }
or
Expand Down

0 comments on commit eb308ba

Please sign in to comment.