Update notifications-ruby and mail-notify 6.0
#9390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inulty-dfe
force-pushed
the
update-notifications-ruby-and-mail-notify-6.0
branch
from
bf88e41 to
9f094e9
Compare
inulty-dfe
had a problem deploying
to
review_aks
GitHub Actions
Failure
Bumps [notifications-ruby-client](https://github.com/alphagov/notifications-ruby-client) and [mail-notify](https://github.com/dxw/mail-notify). These dependencies needed to be updated together. Updates `notifications-ruby-client` from 5.4.0 to 6.0.0 - [Changelog](https://github.com/alphagov/notifications-ruby-client/blob/main/CHANGELOG.md) - [Commits](alphagov/notifications-ruby-client@5.4.0...6.0.0) Updates `mail-notify` from 1.2.0 to 2.0.0 - [Release notes](https://github.com/dxw/mail-notify/releases) - [Changelog](https://github.com/dxw/mail-notify/blob/main/CHANGELOG.md) - [Commits](dxw/mail-notify@1.2.0...2.0.0) --- updated-dependencies: - dependency-name: notifications-ruby-client dependency-type: direct:production update-type: version-update:semver-major - dependency-name: mail-notify dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
inulty-dfe
force-pushed
the
update-notifications-ruby-and-mail-notify-6.0
branch
from
9f094e9 to
58fd9f1
Compare
inulty-dfe
had a problem deploying
to
review_aks
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
PR to update these two libraries to new major version requires some changes that are better made separate to Dependabot
Mail notify has updated to v2 https://github.com/dxw/mail-notify
Notifications ruby has updated to v6 https://github.com/alphagov/notifications-ruby-client
Update
We've discovered a potential bug / unintended behaviour in the
mail-notifygemI've produced a PR, it needs more work. Hopefully it starts a conversation with the maintainers.
dxw/mail-notify#162
Changes proposed in this pull request
Guidance to review
Link to Trello card
Things to check