Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Commit

Permalink
Merge pull request #12 from DFE-Digital/feature/academies-api-contracts
Browse files Browse the repository at this point in the history
added ukprn to school and some other fields for transfers
  • Loading branch information
paullocknimble authored Nov 22, 2023
2 parents cb14e73 + 916466a commit 4ad10c5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<PackageReadmeFile>README.md</PackageReadmeFile>
<RepositoryUrl>https://github.com/DFE-Digital/academisation-nuget-packages</RepositoryUrl>
<RepositoryType>git</RepositoryType>
<Version>1.0.4</Version>
<Version>1.0.5</Version>
<AssemblyVersion>1.0.4</AssemblyVersion>
<FileVersion>1.0.4</FileVersion>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
public class EstablishmentDto
{

public string Ukprn { get; set; }

Check warning on line 7 in academiesContracts/Dfe.Academies.Contracts/V4/Establishments/EstablishmentDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'Ukprn' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
public string Urn { get; set; }

Check warning on line 8 in academiesContracts/Dfe.Academies.Contracts/V4/Establishments/EstablishmentDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'Urn' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
public string Name { get; set; }

Check warning on line 9 in academiesContracts/Dfe.Academies.Contracts/V4/Establishments/EstablishmentDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
public string LocalAuthorityCode { get; set; }

Check warning on line 10 in academiesContracts/Dfe.Academies.Contracts/V4/Establishments/EstablishmentDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'LocalAuthorityCode' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Expand All @@ -18,6 +19,12 @@ public class EstablishmentDto
public string Pan { get; set; }
public string Deficit { get; set; }
public string ViabilityIssue { get; set; }
public string GiasLastChangedDate { get; set; }
public string NoOfBoys { get; set; }
public string NoOfGirls { get; set; }
public string SenUnitCapacity { get; set; }
public string SenUnitOnRoll { get; set; }
public string ReligousEthos { get; set; }
public NameAndCodeDto Diocese { get; set; }
public NameAndCodeDto EstablishmentType { get; set; }
public NameAndCodeDto Gor { get; set; }
Expand Down Expand Up @@ -59,4 +66,7 @@ public class CensusDto
{
public string NumberOfPupils { get; set; }

Check warning on line 67 in academiesContracts/Dfe.Academies.Contracts/V4/Establishments/EstablishmentDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'NumberOfPupils' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
public string PercentageFsm { get; set; }

Check warning on line 68 in academiesContracts/Dfe.Academies.Contracts/V4/Establishments/EstablishmentDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'PercentageFsm' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
public string PercentageFsmLastSixYears { get; set; }

Check warning on line 69 in academiesContracts/Dfe.Academies.Contracts/V4/Establishments/EstablishmentDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'PercentageFsmLastSixYears' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
public string PercentageEnglishAsSecondLanguage { get; set; }

Check warning on line 70 in academiesContracts/Dfe.Academies.Contracts/V4/Establishments/EstablishmentDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'PercentageEnglishAsSecondLanguage' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
public string PercentageSen { get; set; }

Check warning on line 71 in academiesContracts/Dfe.Academies.Contracts/V4/Establishments/EstablishmentDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'PercentageSen' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
}

0 comments on commit 4ad10c5

Please sign in to comment.