Merge pull request #442 from DFE-Digital/feature/161441-soft-delete-p… #2741
elielijah321Annotations
10 warnings
|
build:
Dfe.Academies.Academisation.Core/CommandOrCreateResult.cs#L7
Remove this empty class, write its code or make it an "interface". (https://rules.sonarsource.com/csharp/RSPEC-2094)
|
|
build:
Dfe.Academies.Academisation.Domain.Core/ApplicationAggregate/SchoolDetails.cs#L7
Non-nullable property 'SchoolName' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
|
build:
Dfe.Academies.Academisation.Domain.Core/ApplicationAggregate/ContributorRole.cs#L5
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
|
|
build:
Dfe.Academies.Academisation.Domain.Core/ProjectAggregate/ProjectDetails.cs#L38
Make this an auto-implemented property and remove its backing field. (https://rules.sonarsource.com/csharp/RSPEC-2292)
|
|
build:
Dfe.Academies.Academisation.Domain.Core/ProjectAggregate/ProjectDetails.cs#L40
Make this an auto-implemented property and remove its backing field. (https://rules.sonarsource.com/csharp/RSPEC-2292)
|
|
build:
Dfe.Academies.Academisation.Domain.Core/ProjectAggregate/ProjectDetails.cs#L44
Make this an auto-implemented property and remove its backing field. (https://rules.sonarsource.com/csharp/RSPEC-2292)
|
|
build:
Dfe.Academies.Academisation.Domain.Core/ProjectAggregate/ProjectDetails.cs#L45
Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104)
|
|
build:
Dfe.Academies.Academisation.Domain.Core/ProjectAggregate/ProjectDetails.cs#L116
Make this an auto-implemented property and remove its backing field. (https://rules.sonarsource.com/csharp/RSPEC-2292)
|
|
build:
Dfe.Academies.Academisation.Domain.Core/ProjectAggregate/ProjectDetails.cs#L9
Seal class 'ProjectDetails' or implement 'IEqualityComparer<T>' instead. (https://rules.sonarsource.com/csharp/RSPEC-4035)
|
|
build:
Dfe.Academies.Academisation.Domain.Core/ApplicationAggregate/SchoolDetails.cs#L9
Constructor has 38 parameters, which is greater than the 7 authorized. (https://rules.sonarsource.com/csharp/RSPEC-107)
|