Merge pull request #619 from DFE-Digital/feature/191269-change-grant-… #3706
Annotations
1 error and 11 warnings
|
Build, Test and Analyze
Process completed with exit code 1.
|
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Build, Test and Analyze:
Dfe.Academies.Academisation.Core/CommandOrCreateResult.cs#L7
Remove this empty class, write its code or make it an "interface". (https://rules.sonarsource.com/csharp/RSPEC-2094)
|
|
Build, Test and Analyze:
Dfe.Academies.Academisation.Domain.Core/ApplicationAggregate/SchoolDetails.cs#L7
Non-nullable property 'SchoolName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
|
|
Build, Test and Analyze:
Dfe.Academies.Academisation.Domain.Core/ApplicationAggregate/ContributorRole.cs#L5
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
|
|
Build, Test and Analyze:
Dfe.Academies.Academisation.Domain.Core/ConversionAdvisoryBoardDecisionAggregate/AdvisoryBoardDAORevokedReason.cs#L3
Rename this enumeration to match the regular expression: '^([A-Z]{1,3}[a-z0-9]+)*([A-Z]{2})?$'. (https://rules.sonarsource.com/csharp/RSPEC-2342)
|
|
Build, Test and Analyze:
Dfe.Academies.Academisation.Domain.Core/ReasonChange.cs#L3
Move 'ReasonChange' into a named namespace. (https://rules.sonarsource.com/csharp/RSPEC-3903)
|
|
Build, Test and Analyze:
Dfe.Academies.Academisation.Domain.Core/ReasonChange.cs#L17
Move 'IReasonChange' into a named namespace. (https://rules.sonarsource.com/csharp/RSPEC-3903)
|
|
Build, Test and Analyze:
Dfe.Academies.Academisation.Domain.Core/ConversionAdvisoryBoardDecisionAggregate/AdvisoryBoardDAORevokedReasonDetails.cs#L5
Remove the unused private setter 'set_Id'. (https://rules.sonarsource.com/csharp/RSPEC-1144)
|
|
Build, Test and Analyze:
Dfe.Academies.Academisation.Domain.Core/ConversionAdvisoryBoardDecisionAggregate/AdvisoryBoardDAORevokedReasonDetails.cs#L3
Rename record 'AdvisoryBoardDAORevokedReasonDetails' to match pascal case naming rules, consider using 'AdvisoryBoardDaoRevokedReasonDetails'. (https://rules.sonarsource.com/csharp/RSPEC-101)
|
|
Build, Test and Analyze:
Dfe.Academies.Academisation.Domain.Core/ConversionAdvisoryBoardDecisionAggregate/AdvisoryBoardDeclinedReasonDetails.cs#L5
Remove the unused private setter 'set_Id'. (https://rules.sonarsource.com/csharp/RSPEC-1144)
|
|
Build, Test and Analyze:
Dfe.Academies.Academisation.Domain.Core/ConversionAdvisoryBoardDecisionAggregate/AdvisoryBoardDeferredReasonDetails.cs#L5
Remove the unused private setter 'set_Id'. (https://rules.sonarsource.com/csharp/RSPEC-1144)
|
Loading