Skip to content
.NET

Merge pull request #610 from DFE-Digital/bugfix/trust-ukprn-not-popul… #3674

Sign in to view logs

Merge pull request #610 from DFE-Digital/bugfix/trust-ukprn-not-popul…

Merge pull request #610 from DFE-Digital/bugfix/trust-ukprn-not-popul… #3674

Triggered via push November 25, 2024 12:38
@paullocknimblepaullocknimble
pushed 9dcadae
main
Status Success
Total duration 5m 40s
Artifacts –

build.yml

on: push
lint
19s
lint
build
5m 28s
build
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
build: Dfe.Academies.Academisation.Core/CommandOrCreateResult.cs#L7
Remove this empty class, write its code or make it an "interface". (https://rules.sonarsource.com/csharp/RSPEC-2094)
build: Dfe.Academies.Academisation.Domain.Core/ApplicationAggregate/SchoolDetails.cs#L7
Non-nullable property 'SchoolName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
build: Dfe.Academies.Academisation.Domain.Core/ApplicationAggregate/ContributorRole.cs#L5
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
build: Dfe.Academies.Academisation.Domain.Core/ConversionAdvisoryBoardDecisionAggregate/AdvisoryBoardDAORevokedReason.cs#L3
Rename this enumeration to match the regular expression: '^([A-Z]{1,3}[a-z0-9]+)*([A-Z]{2})?$'. (https://rules.sonarsource.com/csharp/RSPEC-2342)
build: Dfe.Academies.Academisation.Domain.Core/ReasonChange.cs#L17
Move 'IReasonChange' into a named namespace. (https://rules.sonarsource.com/csharp/RSPEC-3903)
build: Dfe.Academies.Academisation.Domain.Core/ReasonChange.cs#L3
Move 'ReasonChange' into a named namespace. (https://rules.sonarsource.com/csharp/RSPEC-3903)
build: Dfe.Academies.Academisation.Domain.Core/ConversionAdvisoryBoardDecisionAggregate/AdvisoryBoardDAORevokedReasonDetails.cs#L5
Remove the unused private setter 'set_Id'. (https://rules.sonarsource.com/csharp/RSPEC-1144)
build: Dfe.Academies.Academisation.Domain.Core/ConversionAdvisoryBoardDecisionAggregate/AdvisoryBoardDAORevokedReasonDetails.cs#L3
Rename record 'AdvisoryBoardDAORevokedReasonDetails' to match pascal case naming rules, consider using 'AdvisoryBoardDaoRevokedReasonDetails'. (https://rules.sonarsource.com/csharp/RSPEC-101)
build: Dfe.Academies.Academisation.Domain.Core/ConversionAdvisoryBoardDecisionAggregate/AdvisoryBoardDeclinedReasonDetails.cs#L5
Remove the unused private setter 'set_Id'. (https://rules.sonarsource.com/csharp/RSPEC-1144)
build: Dfe.Academies.Academisation.Domain.Core/ConversionAdvisoryBoardDecisionAggregate/AdvisoryBoardWithdrawnReasonDetails.cs#L4
Remove the unused private setter 'set_Id'. (https://rules.sonarsource.com/csharp/RSPEC-1144)