SEMVER - MINOR: Release 1.57.0 #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RCP job fails locally https://eaflood.atlassian.net/browse/IWTF-4249 update node modules within package-lock so rcp is able run locally without running npm install within package each time * remove node modules but running install so get updated * update docker files * remove docker changes * update package-lock files * remove from dockerfile * changes to sales and sqs * run npx lerna exec -- npm install * run npx lerna exec -- npm install * change ci to i as wanting to update package-lock
* RCP job fails locally https://eaflood.atlassian.net/browse/IWTF-4249 update node modules within package-lock so rcp is able run locally without running npm install within package each time * remove node modules but running install so get updated * update docker files * remove docker changes * update package-lock files * remove from dockerfile * changes to sales and sqs * run npx lerna exec -- npm install * run npx lerna exec -- npm install * change ci to i as wanting to update package-lock * revert change * change too ci
* FTP POCL references https://eaflood.atlassian.net/browse/IWTF-4279 remove references too ftp POCL env variables * remove pocl references
https://eaflood.atlassian.net/browse/IWTF-4373 Since the actual payments are created using the usual createPayment function, just with recurring as true.
* Apply more specific date error messages https://eaflood.atlassian.net/browse/IWTF-3913 This PR makes use of the new date validations to give more specific date error messages. * Generalise date validation and apply to date of birth page * Added validation for licence to start page * Refactor date of birth and start date validators to be reusable functions, apply them to the date of birth, start date and renewals id page (start date will be applied to renewal start date in a new ticket) * Add function to get error flags for a date, to pass through to the template so the relevant fields can be highlighted --------- Co-authored-by: Phil Benson <[email protected]>
* Change length link junior licence https://eaflood.atlassian.net/browse/IWTF-4404 remove option to change licence length for a junior licence * hide change button for junior
* Create RP Record in CRM https://eaflood.atlassian.net/browse/IWTF-4262 After a successful payment, when the permission is provisioned, a RCP record should be created along with everything else. It shouldn't be created if the RCP toggle is off * add transformer for transaction to calculate next due date as well as put transaction in a shape accepted by processRecurringPayment. Also modified processRecurringPayment to set publicId to be a hash of the recurring payment id * use generateRecurringPaymentRecord to remap transaction so that it can be used by processRecurringPayment * Amended generateRecurringPaymentRecord to take a Permission object rather than using the permission embedded in the transaction, altered transaction queue processor to save RecurringPayment after Permission and Contact, removed contactId and activePermission fields as these were extraneous
https://eaflood.atlassian.net/browse/IWTF-4117 This will hopefully fix the issue we have with dependencies not updating fully. See lerna/lerna#3091
* Fix RP creation bug https://eaflood.atlassian.net/browse/IWTF-4262 A recurring payment is being created for all permissions * Amend generateRecurringPaymentRecord to set recurring flag to false when agreement id isn't present in transaction
* Fix DOB message in Welsh https://eaflood.atlassian.net/browse/IWTF-3913 dob_error message is incorrect in Welsh * Amend message
* Licence to start error not in error summary https://eaflood.atlassian.net/browse/IWTF-3913 On the licence to start page, if no option is selected, the select an option error doesn't appear in the error summary box * Add licence-to-start error back into errorMap
* Update activity in CRM https://eaflood.atlassian.net/browse/IWTF-4401 Update activity in CRM
* Missing inline error on renewals id page https://eaflood.atlassian.net/browse/IWTF-3913 The inline error for date of birth on the renewals identity page is missing, it's only presented in the error summary box * Add inline error for date of birth entry on renewals identification page
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.