Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEMVER - MINOR : Release v1.51.0 #2076

Merged
merged 16 commits into from
Nov 12, 2024
Merged

SEMVER - MINOR : Release v1.51.0 #2076

merged 16 commits into from
Nov 12, 2024

Conversation

lailien3
Copy link
Contributor

No description provided.

ScottDormand96 and others added 16 commits October 21, 2024 13:44
* Update content to 10 days

https://eaflood.atlassian.net/browse/IWTF-4306

Update content on 'How do you want to get yournfishing licence page' from 15 to 10 days

* change wording of content

* welsh
* Payment compllete page 10 days

https://eaflood.atlassian.net/browse/IWTF-4307

Update content on "Payment complete page" from 15 to 10 days for postal licence

* update content
* Update dependencies in package-lock

https://eaflood.atlassian.net/browse/IWTF-4117

update deploy script to update package-lock files

* add line to update package lock by running npm install
* Content amendments to payment summary

https://eaflood.atlassian.net/browse/IWTF-4188

Changing the layout of the payment / licence summary to be more consistent across the service.

* Fixed tests

* Fixed govuk service tests

* Update cy.json

* updated welsh date fomat

* Added welsh dates

* junior / age_junior fixes

* Created and implemented new label
* Create rcp agreement with GOV.UK pay

https://eaflood.atlassian.net/browse/IWTF-4260

Before sending the user to the payment screen on GOV.UK pay, if recurring payment has been selected we need to send a request to create the agreement

* Update prepareRecurringPayment so that it sends the transaction id (now generated in the agreed handler) and doesn't send a user id as we can't determine that at the point we create a recurring payment agreement

---------

Co-authored-by: Phil Benson <[email protected]>
* Update dependencies in package-lock

https://eaflood.atlassian.net/browse/IWTF-4117

update deploy script to update package-lock files

* add line to update package lock by running npm install

* update package-lock to match package.json so can grab correct version in deploy action

* move so packages are deployed to npm so can access

* add a delay to allow npm to register version

* keep consitent bottom of file for packages
* Fix bug where transaction id is not recognised

https://eaflood.atlassian.net/browse/IWTF-4352

On return from GovPay, the transaction is not retrieved because the
transaction id has changed

Fix:
* Only set a transaction id if one hasn't already been set
* Change docker to not install dev dependency

https://eaflood.atlassian.net/browse/IWTF-4280

Change dockerfile to run npm ci instead of npm i so dev dependency not included in docker container

* change npm install too npm ci

* chnage too install production which has same impact as ci
* Building tag error

Move gulp dependency outside of dev so able to build

* move gulp dependencies

* move gulp back and edit docker file

* refactor install line

* chown in build
@lailien3 lailien3 merged commit 1c6e93d into master Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants