Apply more specific date error messages #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/IWTF-3913 This PR makes use of the new date validations to give more specific date error messages.
|
…- invalid dates were failing, but so were valid ones! Added some custom validation to rectify this
…es, added extra test for decimal values against date schema, added validation to date of birth page for no dates before 120 years ago and no dates in the future
…ions, apply them to the date of birth, start date and renewals id page (start date will be applied to renewal start date in a new ticket)
irisfaraway
commented
Nov 22, 2024
There was a problem hiding this comment.
I can't officially approve or reject this since it's technically my PR (although looks like it's all your work!) so someone else will have to stamp this as well.
Do we need to clean up the new date validators in the business-lib since we haven't ended up using them? (createDayValidator, etc)
packages/gafl-webapp-service/src/pages/concessions/date-of-birth/date-of-birth.njk
Outdated
Show resolved
Hide resolved
packages/gafl-webapp-service/src/pages/licence-details/licence-to-start/__tests__/route.spec.js
Show resolved
Hide resolved
…mplate so the relevant fields can be highlighted
irisfaraway
commented
Dec 9, 2024
| } | ||
| } | ||
|
|
||
| export const getErrorFlags = error => { |
There was a problem hiding this comment.
Suggest naming this getDateErrorFlags just so the specific purpose is more clear.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-3913
This PR makes use of the new date validations to give more specific date error messages.