[RUBY-3220] Add project name validation logic to submit proposal #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `project_name_complete?` method to check for blank names, valid characters, and uniqueness. - Introduced `PROJECT_NAME_REGEX` constant in `ProjectNameStep` for name format validation. - Added comprehensive RSpec tests for various project name validation scenarios.
jjromeo
force-pushed
the
RUBY-3220-add-character-validation-on-project-name-field
branch
from
96b217c to
70771ed
Compare
| return add_error(:project_name, "The project name must only contain letters, underscores, hyphens and numbers") | ||
| end | ||
|
|
||
| if PafsCore::Project.where.not(id: project.id).exists?(name: name) |
There was a problem hiding this comment.
The .not threw me - please add a comment explaining that this is to find any other projects with the same name.
There was a problem hiding this comment.
Refactored to improve clarity
PaulDoyle-EA
approved these changes
Sep 17, 2024
PaulDoyle-EA
approved these changes
Sep 18, 2024
jjromeo
deleted the
RUBY-3220-add-character-validation-on-project-name-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project_name_complete?method to check for blank names, valid characters, and uniqueness.PROJECT_NAME_REGEXconstant inProjectNameStepfor name format validation.