Feature/448427 pom subs validation #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IdrisEviden
changed the title
IdrisEviden
changed the title
Fahad-Ali-Eviden
previously approved these changes
Oct 31, 2024
|
Add new settings to README - there is a list of variables there |
mikeymonster
reviewed
Nov 1, 2024
...roducerContentValidation.Application.UnitTests/Services/Helpers/FindMatchingProducerTests.cs
Outdated
Show resolved
Hide resolved
|
There are quite a few new files that don't use file-scoped namespaces. It wouldn't take change them to be consistent with existing files . |
mikeymonster
reviewed
Nov 1, 2024
...ducerContentValidation.Application/Services/Helpers/ValidationServiceProducerRowValidator.cs
Outdated
Show resolved
Hide resolved
…om/DEFRA/epr-pom-func-producer-validation into feature/448427-pom-subs-validation
…om/DEFRA/epr-pom-func-producer-validation into feature/448427-pom-subs-validation
mikeymonster
approved these changes
Nov 1, 2024
This can be left for a later refactoring |
Fahad-Ali-Eviden
approved these changes
Nov 1, 2024
IdrisEviden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.