Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory issues #185

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix memory issues #185

wants to merge 7 commits into from

Commits on Oct 5, 2024

  1. fix a few memory leaks

    @stbuehler
    stbuehler committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    9dae6fb View commit details
    Browse the repository at this point in the history

  2. append PKGLIBDIR"/cmd" in TTYMUX_NEW 

    instead of doing so in all invocations and allocating a new array.
    @stbuehler
    stbuehler committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    1eb68ab View commit details
    Browse the repository at this point in the history

  3. ttymux: free old screens/sessions on (new) ttymux_update_sessions 

    - fixes a memory leak
- prepare for further fixes:
  change TTYMUX_GET_SESSIONS to return list instead of modifying
  HostNode->screens, so it can be used in places that expect
  HostNode->screens not to change
    @stbuehler
    stbuehler committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    db7de04 View commit details
    Browse the repository at this point in the history

  4. TTYMUX_ATTACH: fix use after free - don't update session list, it is … 

    …used by the UI

Still fetch session list, but only use it to check if session is alive;
don't store it.
    @stbuehler
    stbuehler committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    3260cd0 View commit details
    Browse the repository at this point in the history

  5. make handleXMLError actually use a const pointer 

    also use xmlResetLastError instead of xmlResetError, as the latter wants
a non-const pointer, but xmlGetLastError returns a const one.
    @stbuehler
    stbuehler committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    58f1796 View commit details
    Browse the repository at this point in the history

  6. sscanf: fix cluster buffer length, and remove unnecessary manual zero… 

    … termination
    @stbuehler
    stbuehler committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    c35e6e3 View commit details
    Browse the repository at this point in the history

  7. sscanf: remove wrong (too short) and unnecessary zero termination of … 

    …uuid field
    @stbuehler
    stbuehler committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    7c9a8ef View commit details
    Browse the repository at this point in the history