[Core] RxFlow로 코디네이터의 기본적인 구조를 설계했어요. #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyine0924
changed the title
woookDev
reviewed
Apr 4, 2022
| private let dependency: Dependency | ||
|
|
||
|
|
||
| init(with dependency: Dependency) { |
There was a problem hiding this comment.
공유주신대로 dependency를 가져야 되는 군요ㅠ ㅎㅎ 다른 대안이 저도 떠오르지 않아서 이렇게 구성해야 할듯요
There was a problem hiding this comment.
네네 Flow에서 ViewController를 보내는 형태가 되어서 생성시점에 의존성을 넘겨주려면 Flow가 프로퍼티로 들고있어야겠더라구요..
jinsu3758
reviewed
Apr 16, 2022
| import RxSwift | ||
| import RxRelay | ||
|
|
||
| struct AppStepper: Stepper { |
There was a problem hiding this comment.
샘플로 찾아본 예제에서 struct로 설계했어서 크게 고려하지 않았었습니다.
RxFlowDemo를 보니 class로 사용하고 있네요. Stepper의 기능적인 면으로 봤을 때 클래스로 사용하는것이 바람직해보입니다!
참고
피드백 주셔서 감사합니다!!
jinsu3758
approved these changes
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RxFlow에 대한 기본 개념은 다음의 링크를 참고하셔서 역할별로만 보셔도 좋을것 같아요. 참고
수정내역 (필수)