Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filtered_movement_regressors.m #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cindyhfls
Copy link

replace iirnotch with butter, remove repeated application of the same filter, only divide the order by 2 if it is using filtfilt()

remove the conversion from degrees to arc length for rotational movements since this will be calculated in a later step (also here it uses default brain radius of 50 mm and does not take an input which is not consistent with the main script).

(there's one more line I need to fix but I don't know how to go back to it so I'll submit another one )

replace iirnotch with butter, remove repeated application of the same filter, only divide the order by 2 if it is using filtfilt()

remove the conversion from degrees to arc length for rotational movements since this will be calculated in a later step (also here it uses default brain radius of 50 mm and does not take an input which is not consistent with the main script).
Copy link
Author

@cindyhfls cindyhfls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 38, order/2 should be order because I moved that part out to line 29 already. Don't know how to make that change on top of this commmit.

@LuciMoore
Copy link
Contributor

related to #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants