Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTM-58265 - add support for event binary api #473

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

d-mariak
Copy link
Contributor

No description provided.

@d-mariak d-mariak requested review from a team December 18, 2024 11:33
Copy link
Contributor

@jkot-c8y jkot-c8y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to create some integration tests similar to com.cumulocity.sdk.client.inventory.BinariesApiIT

import static org.assertj.core.api.Assertions.catchThrowable;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.*;
import static org.mockito.Mockito.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can remove hamcrest and only use assertJ assertions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants